[webkit-reviews] review denied: [Bug 47799] [gtk] clang build fails in X11/Intrinsic.h due to String name conflict : [Attachment 111215] Patch with author/changelog

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied ojab <ojab at ojab.ru>'s request
for review:
Bug 47799: [gtk] clang build fails in X11/Intrinsic.h due to String name
conflict
https://bugs.webkit.org/show_bug.cgi?id=47799

Attachment 111215: Patch with author/changelog
https://bugs.webkit.org/attachment.cgi?id=111215&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111215&action=review


Sorry. Should have mentioned the thing below before. Do you mind alos removing
the "No new tests" line from the ChangeLog. The commit queue won't land the
patch with that there.

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:76
> +#define String XtStringType
>  #if defined(XP_UNIX)
>  #include "RefPtrCairo.h"
>  #include "gtk2xtbin.h"

Hrm. I'm guessing this should be inside the #if defined(XP_UNIX) block?

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:86
> +#undef String

Same here...shouldn't this be up above?

> Source/WebCore/ChangeLog:7
> +	   No new tests. (OOPS!)

Please remove this line.