[webkit-reviews] review denied: [Bug 69937] Web Inspector: BreakpointManager should operate on SourceMappings. : [Attachment 110691] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 16 10:46:58 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 69937: Web Inspector: BreakpointManager should operate on SourceMappings.
https://bugs.webkit.org/show_bug.cgi?id=69937

Attachment 110691: Patch
https://bugs.webkit.org/attachment.cgi?id=110691&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Introducing SourceMappings brings the code complexity beyond the level I feel
comfortable reviewing. I think we should simplify what we have prior to adding
more complexity. Is there a design doc outlining the relationships and
ownership between the UISourceCode, RawSourceCode, SourceFrame and
DebuggerPresentationModel? I am interested in learning the "life of a
breakpoint" and how it is affected by the source mapping installation.


More information about the webkit-reviews mailing list