[webkit-reviews] review denied: [Bug 70033] Web Inspector: move JS specific popover handling to JavaScriptSourceFrame. : [Attachment 110860] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 70033: Web Inspector: move JS specific popover handling to
JavaScriptSourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=70033

Attachment 110860: Patch
https://bugs.webkit.org/attachment.cgi?id=110860&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110860&action=review


> Source/WebCore/inspector/front-end/SourceFrame.js:836
> +    shouldShowPopover: function(element) { },

It is not clear what part of extensibility is achieved by means of the delegate
versus the abstract methods. You should choose one way of extensibility and
stick to it. r- for that.