[webkit-reviews] review granted: [Bug 69341] Web Inspector: Fix GoToLineDialog and extract common dialog functionality. : [Attachment 110531] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 69341: Web Inspector: Fix GoToLineDialog and extract common dialog
functionality.
https://bugs.webkit.org/show_bug.cgi?id=69341

Attachment 110531: Patch
https://bugs.webkit.org/attachment.cgi?id=110531&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110531&action=review


> Source/WebCore/inspector/front-end/Dialog.js:94
> +	       if (typeof(this._dialogDelegate.defaultFocusedElement.select)
=== "function")

This check is hard to compile

> Source/WebCore/inspector/front-end/Dialog.js:148
> +    get okButton() { },

What if the dialog is YesNo ?