[webkit-reviews] review granted: [Bug 64865] Switch isQuirkValue() virtual function to inline one. : [Attachment 111152] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 16 02:05:53 PDT 2011


Eric Seidel <eric at webkit.org> has granted David Barr <davidbarr at chromium.org>'s
request for review:
Bug 64865: Switch isQuirkValue() virtual function to inline one.
https://bugs.webkit.org/show_bug.cgi?id=64865

Attachment 111152: Patch
https://bugs.webkit.org/attachment.cgi?id=111152&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111152&action=review


Seems OK.

> Source/WebCore/css/CSSPrimitiveValue.h:257
> -    signed m_type : 31;
> +    signed m_type : 30;

Why is m_type bigger than it needs to be?


More information about the webkit-reviews mailing list