[webkit-reviews] review granted: [Bug 64865] Switch isQuirkValue() virtual function to inline one. : [Attachment 111150] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Barr <davidbarr at chromium.org>'s
request for review:
Bug 64865: Switch isQuirkValue() virtual function to inline one.
https://bugs.webkit.org/show_bug.cgi?id=64865

Attachment 111150: Patch
https://bugs.webkit.org/attachment.cgi?id=111150&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111150&action=review


> Source/WebCore/css/CSSPrimitiveValue.h:140
> +    /*
> +	* This value is used to handle quirky margins in reflow roots (body,
td, and th) like WinIE.
> +	* The basic idea is that a stylesheet can use the value __qem (for
quirky em) instead of em.
> +	* When the quirky value is used, if you're in quirks mode, the margin
will collapse away
> +	* inside a table cell.
> +	*/

We use "//" comments, not "/*" comments. Not sure why you changed this one.

> Source/WebCore/css/CSSPrimitiveValue.h:143
> +	   CSSPrimitiveValue *ptr = new CSSPrimitiveValue(value, type);

The "*" goes next to the type, not the local variable name.

Instead of ptr this local variable should be named value.