[webkit-reviews] review granted: [Bug 70173] REGRESSION(r97533): fast/forms/select-script-onchange.html failed after : [Attachment 111146] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 15 14:40:32 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 70173: REGRESSION(r97533): fast/forms/select-script-onchange.html failed
after
https://bugs.webkit.org/show_bug.cgi?id=70173

Attachment 111146: Patch
https://bugs.webkit.org/attachment.cgi?id=111146&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111146&action=review


> Source/WebCore/html/HTMLSelectElement.cpp:1009
> +	       setSelectedIndex(listToOptionIndex(listIndex), true, false,
true);

These boolean values are hurting my eyes :(


More information about the webkit-reviews mailing list