[webkit-reviews] review granted: [Bug 64865] Switch isQuirkValue() virtual function to inline one. : [Attachment 111125] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Barr <davidbarr at chromium.org>'s
request for review:
Bug 64865: Switch isQuirkValue() virtual function to inline one.
https://bugs.webkit.org/show_bug.cgi?id=64865

Attachment 111125: Patch
https://bugs.webkit.org/attachment.cgi?id=111125&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111125&action=review


Not setting commit-queue+ because of David’s comment, and my related one.

>> Source/WebCore/css/CSSQuirkPrimitiveValue.h:-31
>> -// inside a table cell.
> 
> I think this comment should have followed CSSQuirkPrimitiveValue::create()
when it became CSSPrimitiveValue::createQuirk().

I agree. I also would suggest naming the new function
CSSPrimitiveValue::createAllowingMarginQuirk().