[webkit-reviews] review granted: [Bug 70164] Make toHTMLElement fail to compile if you try to use it on an HTMLElement* : [Attachment 111118] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 70164: Make toHTMLElement fail to compile if you try to use it on an
HTMLElement*
https://bugs.webkit.org/show_bug.cgi?id=70164

Attachment 111118: Patch
https://bugs.webkit.org/attachment.cgi?id=111118&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111118&action=review


> Source/WebCore/bindings/js/JSHTMLFrameSetElementCustom.cpp:54
> +    if (Document* document =
static_cast<HTMLFrameElement*>(frameElement)->contentDocument()) {

I know this is in the original code, but it's unclear to me what makes this
cast safe.  It seems like you could add non HTMLFrameElement children to an
HTMLFrameSetElement via the DOM (though not with the parser).