[webkit-reviews] review granted: [Bug 70157] FunctionExecutable should expose the ability to create unattached FunctionCodeBlocks : [Attachment 111108] the patch - fix style

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 70157: FunctionExecutable should expose the ability to create unattached
FunctionCodeBlocks
https://bugs.webkit.org/show_bug.cgi?id=70157

Attachment 111108: the patch - fix style
https://bugs.webkit.org/attachment.cgi?id=111108&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111108&action=review


r=me

> Source/JavaScriptCore/runtime/Executable.cpp:416
> +	   return PassOwnPtr<FunctionCodeBlock>();

I think you can just return nullptr here.

> Source/JavaScriptCore/runtime/Executable.cpp:427
> +    result = adoptPtr(new FunctionCodeBlock(this, FunctionCode,
globalObject, source().provider(), source().startOffset(), specializationKind
== CodeForConstruct, PassOwnPtr<FunctionCodeBlock>()));

nullptr, or maybe just make that the default function argument.

> Source/JavaScriptCore/runtime/Executable.cpp:432
> +	   return PassOwnPtr<FunctionCodeBlock>();

nullptr