[webkit-reviews] review requested: [Bug 70158] Fix clang compiler warnings : [Attachment 111110] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 70158: Fix clang compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=70158

Attachment 111110: Patch
https://bugs.webkit.org/attachment.cgi?id=111110&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Source/WebCore:

* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes): Use std::max<float>()
instead of std::max().

Source/WebKit/mac:

The following two methods in WebDelegateImplementationCaching.h
are ambiguous in WebChromeClient::runJavaScriptPrompt() because
the compiler can't decide how to convert the WebCore::String
defaultText argument:

id CallUIDelegate(WebView *, SEL, id, id);
id CallUIDelegate(WebView *, SEL, id, BOOL);

The fix is to perform the conversion explicitly.

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::runJavaScriptPrompt): Extract a defaultString
variable to convert the WebCore::String to an NSString*, then
use defaultString in place of defaultText.
---
 4 files changed, 39 insertions(+), 7 deletions(-)