[webkit-reviews] review granted: [Bug 70154] watchlist: Add a validation check for the email names in the list. : [Attachment 111102] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 70154: watchlist: Add a validation check for the email names in the list.
https://bugs.webkit.org/show_bug.cgi?id=70154

Attachment 111102: Patch
https://bugs.webkit.org/attachment.cgi?id=111102&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111102&action=review


> Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:137
> +		       raise Exception("The email alias %s which is in the
watchlist is not listed as a contributor in committers.py" % email)

I see that we've already using Exception in this class, but it's usually good
form to use a subclass of exception so that folks can catch these parse errors
without catching all manner of exceptions.

(Just a general note.  Nothing that needs to be addressed now.)