[webkit-reviews] review denied: [Bug 59199] [Qt][WK2] Implement geolocation provider for qt port : [Attachment 111059] Setting to mutable the GeoPositionSource class member (thus respecting WKGeolocationManager const pointers)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 14 13:16:59 PDT 2011


Andreas Kling <kling at webkit.org> has denied Adenilson Cavalcanti Silva
<adenilson.silva at openbossa.org>'s request for review:
Bug 59199: [Qt][WK2] Implement geolocation provider for qt port
https://bugs.webkit.org/show_bug.cgi?id=59199

Attachment 111059: Setting to mutable the GeoPositionSource class member (thus
respecting WKGeolocationManager const pointers)
https://bugs.webkit.org/attachment.cgi?id=111059&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111059&action=review


> Source/WebKit2/ChangeLog:6
> +	   Reviewed by Simon Hausmann <hausmann at webkit.org>

This line needs to be omitted until the patch gets a proper r+.

> Source/WebKit2/ChangeLog:12
> +
> +

One newline is enough here.


More information about the webkit-reviews mailing list