[webkit-reviews] review granted: [Bug 62112] Context-aware HTML paste for Chromium : [Attachment 111046] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 14 12:19:43 PDT 2011

Ryosuke Niwa <rniwa at webkit.org> has granted Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 62112: Context-aware HTML paste for Chromium

Attachment 111046: Patch

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111046&action=review

> Source/WebCore/editing/markup.cpp:711
> +const char fragmentMarkerTag[] = "webkit-fragment-marker";

Nit: missing static.

> Source/WebCore/editing/markup.cpp:713
> +bool findNodesSurroundingContext(Document* document, RefPtr<Node>&
nodeBeforeContext, RefPtr<Node>& nodeAfterContext)

Nit: missing static (this is going to cause a compilation error on some

> Source/WebCore/platform/chromium/ChromiumDataObject.cpp:-270
> -

Are you deleting a blank line? Or removing the last line break from the line
(which is bad)?

More information about the webkit-reviews mailing list