[webkit-reviews] review granted: [Bug 70116] CSSStyleSheet should only ever contain CSSRules. : [Attachment 111029] Proposed patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 70116: CSSStyleSheet should only ever contain CSSRules.
https://bugs.webkit.org/show_bug.cgi?id=70116

Attachment 111029: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=111029&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=111029&action=review


Nice! r=me, with one change.

> Source/WebCore/css/CSSStyleSheet.h:113
> +    unsigned length() const { return m_children.size(); }
> +    CSSRule* item(unsigned index) { return index < length() ?
m_children.at(index).get() : 0; }

Just go ahead and expose the vector instead here 
const Vector<RefPtr<CSSRule> >& rules() const

> Source/WebCore/xml/XSLStyleSheet.h:60
> +    unsigned length() const { return m_children.size(); }
> +    StyleBase* item(unsigned index) { return index < length() ?
m_children.at(index).get() : 0; }

here too