[webkit-reviews] review granted: [Bug 64865] Switch isQuirkValue() virtual function to inline one. : [Attachment 110959] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 14 08:44:58 PDT 2011

Darin Adler <darin at apple.com> has granted David Barr <davidbarr at chromium.org>'s
request for review:
Bug 64865: Switch isQuirkValue() virtual function to inline one.

Attachment 110959: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
This idea is fine, but there is no reason to keep an entire class,
CSSQuirkPrimitiveValue, any more given that the class has no contents. Instead
we just need a new create function in CSSPrimitiveValue that creates a quirk

Doing it that way will remove an entire unnecessary vtable, make the code
cleaner and easier to understand, and also remove the need to add new protected

I’m going to say review+ but I’d much prefer this be redone to eliminate the

More information about the webkit-reviews mailing list