[webkit-reviews] review granted: [Bug 70088] canvas getImageData should explain why it throws SECURITY_ERR : [Attachment 110956] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 14 08:37:17 PDT 2011


Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 70088: canvas getImageData should explain why it throws SECURITY_ERR
https://bugs.webkit.org/show_bug.cgi?id=70088

Attachment 110956: Patch
https://bugs.webkit.org/attachment.cgi?id=110956&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110956&action=review


> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1762
> +	   DEFINE_STATIC_LOCAL(String, consoleMessage, ("Unable to get image
data from canvas because the canvas has been tainted by cross-origin
data.\n"));

Do these messages really need newlines? I think this is an extra unneeded
newline.


More information about the webkit-reviews mailing list