[webkit-reviews] review granted: [Bug 70109] Stricter management of WebKitCSSKeyframeRules. : [Attachment 111015] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 14 08:12:14 PDT 2011
Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 70109: Stricter management of WebKitCSSKeyframeRules.
https://bugs.webkit.org/show_bug.cgi?id=70109
Attachment 111015: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=111015&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=111015&action=review
r=me, with one change
> Source/WebCore/css/StyleBase.h:-55
> - virtual bool isKeyframeRule() const { return false; }
Please keep this so you can assert before casting.
> Source/WebCore/css/WebKitCSSKeyframesRule.cpp:80
> + return static_cast<const
WebKitCSSKeyframeRule*>(m_lstCSSRules->item(index));
assert here.
More information about the webkit-reviews
mailing list