[webkit-reviews] review granted: [Bug 70037] [Qt] enable qmltests for qt5 : [Attachment 110875] enable qmltests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 14 06:34:51 PDT 2011

Chang Shu <cshu at webkit.org> has granted Gopal Raghavan
<gopal.1.raghavan at nokia.com>'s request for review:
Bug 70037: [Qt] enable qmltests for qt5

Attachment 110875: enable qmltests

------- Additional Comments from Chang Shu <cshu at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110875&action=review

The code change is ok but better to communicate with Ossy when to land this
patch. After landing, please also keep an eye on the bot:

> Source/WebKit2/ChangeLog:8
> +	   Qml tests seem to be disabled for some reason. This patch enables
the tests by including qmltests to SUBDIRS.

Please wrap the description in the future.

More information about the webkit-reviews mailing list