[webkit-reviews] review requested: [Bug 61558] iframe with scrolling=no incorrectly autoscrollable : [Attachment 110984] Patch to fix scrolling of frame content with "scrolling=no"

[bugzilla-daemon at webkit.org]

Swapna <spottabathini at innominds.com> has asked	for review:
Bug 61558: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558

Attachment 110984: Patch to fix scrolling of frame content with "scrolling=no"
https://bugs.webkit.org/attachment.cgi?id=110984&action=review

------- Additional Comments from Swapna <spottabathini at innominds.com>
Hi,
As per the spec I came to know that,if iframe attribute is scrolling="no" then
it should n't allow scroll of frame content.
As per my observation, when I load the mentioned test case, it is not showing
any scroll bar(correct behaviour).
But when we click & drag on the content of iframe, content is getting scrolled.


In function  RenderLayer::scrollRectToVisible scroll is applied on frame
content for  mouse click & drag  event.
But here before applying scroll on frame content, need to check for frame's
scrolling mode.
So if we add the check for frame's scrolling mode before applying scroll( see
the patch), the issue is getting resolved.

And in the test case, if frame content scrolled is "zero" then it is printing
log as "FAILED".
But it should print "PASSED" as per the description provided in test case.
So I changed the test case accordingly (see the patch).
Can any one please review the patch?