[webkit-reviews] review denied: [Bug 69859] [Qt][WK2] ASSERT when displaying context menu in input field : [Attachment 110554] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 14 01:48:32 PDT 2011

Simon Hausmann <hausmann at webkit.org> has denied Dinu Jacob
<dinu.jacob at Nokia.com>'s request for review:
Bug 69859: [Qt][WK2] ASSERT when displaying context menu in input field

Attachment 110554: Patch

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110554&action=review

> Source/WebKit2/UIProcess/qt/WebContextMenuProxyQt.cpp:115
> -		   static_cast<QObject*>(subMenu.get())->setParent(menu.get());

> +		   subMenu->setParent(menu.get());

Could you explain (for example in the changelog or whereever appropriate) why
your patch fixes the assert?

Please also mention what assert exactly :)

More information about the webkit-reviews mailing list