[webkit-reviews] review denied: [Bug 69572] [Qt] QTouchWebView missing navigationPolicyForUrl : [Attachment 110864] updated patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Gopal Raghavan
<gopal.1.raghavan at nokia.com>'s request for review:
Bug 69572: [Qt] QTouchWebView missing navigationPolicyForUrl
https://bugs.webkit.org/show_bug.cgi?id=69572

Attachment 110864: updated patch
https://bugs.webkit.org/attachment.cgi?id=110864&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110864&action=review


We want to do this in a different way

> Source/WebKit2/ChangeLog:8
> +	   Implemented navigationPolicyForUrl. This is similar to
DesktopWebView implementation. It provides the flexibiltiy to specify custom
navigation policies for TouchWebView.

Please break that line

>
Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_navigationPolic
yForUrl.qml:16
> +	   function navigationPolicyForUrl(url, button, modifiers) {
> +	       if (button == Qt.MiddleButton && modifiers & Qt.ControlModifier)
{
> +		   otherWebView.page.load(url)
> +		   return TouchWebView.IgnorePolicy
> +	       }
> +	       return TouchWebView.UsePolicy
> +	   }

We decided to do this differently. Simon had some better ideas. Please check
the ML