[webkit-reviews] review granted: [Bug 70076] [chromium] Make it possible for plugins to get current fullscreen element. : [Attachment 110969] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 13 23:52:59 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted
polina at chromium.org's request for review:
Bug 70076: [chromium] Make it possible for plugins to get current fullscreen
element.
https://bugs.webkit.org/show_bug.cgi?id=70076

Attachment 110969: Patch
https://bugs.webkit.org/attachment.cgi?id=110969&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110969&action=review


> Source/WebKit/chromium/src/WebDocument.cpp:195
> +    Element* fullScreenElement =
constUnwrap<Document>()->webkitCurrentFullScreenElement();

I believe the following should work too:

  return WebElement(constUnwrap<Document>()->webkitCurrentFullScreenElement());


It can handle being initialized with a NULL Element.


More information about the webkit-reviews mailing list