[webkit-reviews] review denied: [Bug 70055] [WK2] WebFrameLoaderClient::shouldFallback() should use a port-specific implementation : [Attachment 110909] Patch

[bugzilla-daemon at webkit.org]

Luiz Agostini <luiz at webkit.org> has denied Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 70055: [WK2] WebFrameLoaderClient::shouldFallback() should use a
port-specific implementation
https://bugs.webkit.org/show_bug.cgi?id=70055

Attachment 110909: Patch
https://bugs.webkit.org/attachment.cgi?id=110909&action=review

------- Additional Comments from Luiz Agostini <luiz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110909&action=review


> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:-985
> -    DEFINE_STATIC_LOCAL(const ResourceError, cancelledError,
(this->cancelledError(ResourceRequest())));
> -    DEFINE_STATIC_LOCAL(const ResourceError, pluginWillHandleLoadError,
(this->pluginWillHandleLoadError(ResourceResponse())));

r- because you ignored static and const in all the implementations of
shouldFallBack that you provided.

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:93
> +    ResourceError errorCancelled = cancelledError(ResourceRequest());
> +    ResourceError errorPluginWillHandleLoad =
pluginWillHandleLoadError(ResourceResponse());

Ditto.

> Source/WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:91
> +    ResourceError errorCancelled = cancelledError(ResourceRequest());
> +    ResourceError errorPluginWillHandleLoad =
pluginWillHandleLoadError(ResourceResponse());
> +    ResourceError errorInterruptedForPolicyChange =
interruptedForPolicyChangeError(ResourceRequest());

Ditto.

> Source/WebKit2/WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:84
> +    ResourceError errorCancelled = cancelledError(ResourceRequest());
> +    ResourceError errorPluginWillHandleLoad =
pluginWillHandleLoadError(ResourceResponse());

Ditto.