[webkit-reviews] review granted: [Bug 69774] REGRESSION: High frequency memory warnings cause Safari to hog the CPU doing useless garbage collection : [Attachment 110778] Patch that cancels event handlers and reinstalls after delay

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 13 15:24:07 PDT 2011


Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 69774: REGRESSION: High frequency memory warnings cause Safari to hog the
CPU doing useless garbage collection
https://bugs.webkit.org/show_bug.cgi?id=69774

Attachment 110778: Patch that cancels event handlers and reinstalls after delay
https://bugs.webkit.org/attachment.cgi?id=110778&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110778&action=review


r=me

> Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:71
> +    if (_timer_event_source) {
> +	   dispatch_source_cancel(_timer_event_source);
> +	   _timer_event_source = 0;
> +    }

I think this timer cleanup code should go in the timer handler.

If you want, maybe you should add an early return here, so that if the timer is
set, and we're supposed to hold off, we ignore new install calls, which would
violate our rate limiting plan.


More information about the webkit-reviews mailing list