[webkit-reviews] review denied: [Bug 70056] [webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom : [Attachment 110908] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 70056: [webkit-patch] Put Source/Tools changes at the top of patches,
LayoutTests at the bottom
https://bugs.webkit.org/show_bug.cgi?id=70056

Attachment 110908: Patch
https://bugs.webkit.org/attachment.cgi?id=110908&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110908&action=review


> Tools/Scripts/webkitpy/common/checkout/scm/git.py:255
> +	   order_file = tempfile.NamedTemporaryFile()

Should this just be a static file in the config directory?  (You can look at
the watchlist config file to see how to find the path to config files.)  That
seems better that creating and destroying it every time.

Also, please include a test.