[webkit-reviews] review granted: [Bug 29447] Replaced elements squeezed when width is specified as percentage inside a table with Auto layout : [Attachment 110737] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 29447: Replaced elements squeezed when width is specified as percentage
inside a table with Auto layout
https://bugs.webkit.org/show_bug.cgi?id=29447

Attachment 110737: Patch
https://bugs.webkit.org/attachment.cgi?id=110737&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110737&action=review


r=me.

> Source/WebCore/rendering/RenderBox.cpp:1274
> +enum IntrinsicDimension { Height, Width };

Should use LogicalHeight and LogicalWidth here. Let's not make the terms so
generic either... How about LogicalHeightDimension, LogicalWidthDimension?