[webkit-reviews] review granted: [Bug 68911] Sync requestAnimationFrame callback to CVDisplayLink on Mac : [Attachment 110870] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 68911: Sync requestAnimationFrame callback to CVDisplayLink on Mac
https://bugs.webkit.org/show_bug.cgi?id=68911

Attachment 110870: Patch
https://bugs.webkit.org/attachment.cgi?id=110870&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110870&action=review


> Source/WebCore/dom/ScriptedAnimationController.h:91
> +    void displayRefreshFired(double timestamp) {
serviceScriptedAnimations(convertSecondsToDOMTimeStamp(timestamp)); }

Declare as virtual to make it more obvious that it's implementing the client
interface.

> Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp:121
> +    size_t i = findMonitor(client->m_displayID);
> +    if (i == notFound)
> +	   return;
> +    

i -> index