[webkit-reviews] review granted: [Bug 70015] Constructor should not be called if the object is being constructed inside WebCore : [Attachment 110823] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 70015: Constructor should not be called if the object is being constructed
inside WebCore
https://bugs.webkit.org/show_bug.cgi?id=70015

Attachment 110823: Patch
https://bugs.webkit.org/attachment.cgi?id=110823&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110823&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1536
> +    if (AllowAllocation::current())
> +	   return args.Holder();

Do we need this check in any of our custom constructors as well?  I don't fully
understand in which cases AllowAllocation::current() return true.