[webkit-reviews] review denied: [Bug 59199] [Qt][WK2] Implement geolocation provider for qt port : [Attachment 110568] Previous fixes plus using Qt5 location.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 13 10:15:28 PDT 2011


Simon Hausmann <hausmann at webkit.org> has denied Adenilson Cavalcanti Silva
<adenilson.silva at openbossa.org>'s request for review:
Bug 59199: [Qt][WK2] Implement geolocation provider for qt port
https://bugs.webkit.org/show_bug.cgi?id=59199

Attachment 110568: Previous fixes plus using Qt5 location.
https://bugs.webkit.org/attachment.cgi?id=110568&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110568&action=review


r- because of the const stuff. Otherwise the patch looks good to me.

> Source/WebKit2/ChangeLog:6
> +	   Author: kenneth.r.christiansen at nokia.com

If you want to, you could also write:

"Based on patch by Kenneth Christiansen <his email here>"

> Source/WebKit2/UIProcess/API/C/WKGeolocationManager.h:-43
> -typedef void
(*WKGeolocationProviderStartUpdatingCallback)(WKGeolocationManagerRef
geolocationManager, const void* clientInfo);
> -typedef void
(*WKGeolocationProviderStopUpdatingCallback)(WKGeolocationManagerRef
geolocationManager, const void* clientInfo);
> +typedef void
(*WKGeolocationProviderStartUpdatingCallback)(WKGeolocationManagerRef
geolocationManager, void* clientInfo);
> +typedef void
(*WKGeolocationProviderStopUpdatingCallback)(WKGeolocationManagerRef
geolocationManager, void* clientInfo);
>  
>  struct WKGeolocationProvider {
> -    int								  
version;
> -    const void *							  
clientInfo;
> -    WKGeolocationProviderStartUpdatingCallback			  
startUpdating;
> -    WKGeolocationProviderStopUpdatingCallback			  
stopUpdating;

I do think that removing the const is a problem here. I bet Safari 5 is using
this API to implement gelocation. Also the const - as ugly as it is - is the
pattern used in all of the public WK2 C API.


More information about the webkit-reviews mailing list