[webkit-reviews] review granted: [Bug 69747] FEComponentTransfer element doesn't support dynamic invalidation : [Attachment 110851] Propsed patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Renata Hodovan
<reni at webkit.org>'s request for review:
Bug 69747: FEComponentTransfer element doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=69747

Attachment 110851: Propsed patch
https://bugs.webkit.org/attachment.cgi?id=110851&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110851&action=review


r=me, please fix this before landing:

> Source/WebCore/svg/SVGComponentTransferFunctionElement.cpp:144
> +    if (attrName == SVGNames::typeAttr
> +	   || attrName == SVGNames::tableValuesAttr
> +	   || attrName == SVGNames::slopeAttr
> +	   || attrName == SVGNames::interceptAttr
> +	   || attrName == SVGNames::amplitudeAttr
> +	   || attrName == SVGNames::exponentAttr
> +	   || attrName == SVGNames::offsetAttr) {

This is useless, isSupportedAttribute() checks the same, if that returned true,
it's one of these attributes :-).

> Source/WebCore/svg/SVGComponentTransferFunctionElement.cpp:149
> +	   invalidateFilterPrimitiveParent(this);
> +	   return;
> +    }
> +
> +    ASSERT_NOT_REACHED();

Just make this: invalidateFilterPrimitiveParent(this);