[webkit-reviews] review denied: [Bug 70016] [WebKit2][gtk] Add documentation for WebKitPluginError and WebKitPolicyError. : [Attachment 110826] Add missing documentation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 13 08:32:51 PDT 2011
Martin Robinson <mrobinson at webkit.org> has denied Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 70016: [WebKit2][gtk] Add documentation for WebKitPluginError and
WebKitPolicyError.
https://bugs.webkit.org/show_bug.cgi?id=70016
Attachment 110826: Add missing documentation
https://bugs.webkit.org/attachment.cgi?id=110826&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110826&action=review
Looks good, except for one small nit.
> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:58
> + * @WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL: Load failure due to url that can
not be shown
url should actually say "URI"
This also suggests that we should rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to
WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI in another bug.
More information about the webkit-reviews
mailing list