[webkit-reviews] review granted: [Bug 69028] [chromium] Add a selectionBounds() method to WebWidget. : [Attachment 110784] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 22:15:23 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Peng Huang
<penghuang at chromium.org>'s request for review:
Bug 69028: [chromium] Add a selectionBounds() method to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=69028

Attachment 110784: Patch
https://bugs.webkit.org/attachment.cgi?id=110784&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110784&action=review


still R=me otherwise.

> Source/WebKit/chromium/src/WebViewImpl.cpp:1573
> +	 return false;

nit: should be 4 space indent.	sorry for not catching this earlier :(


More information about the webkit-reviews mailing list