[webkit-reviews] review denied: [Bug 67268] [NRWT] New tests without expected files are reported as flakey tests : [Attachment 110786] Revert some change in expected result

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 18:51:10 PDT 2011


Ojan Vafai <ojan at chromium.org> has denied  review:
Bug 67268: [NRWT] New tests without expected files are reported as flakey tests
https://bugs.webkit.org/show_bug.cgi?id=67268

Attachment 110786: Revert some change in expected result
https://bugs.webkit.org/attachment.cgi?id=110786&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110786&action=review


Are there any tests for this that you can update?

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:142
> +	       num_flaky += 1

Why would we increment num_flaky if we're no longer considering this flaky?


More information about the webkit-reviews mailing list