[webkit-reviews] review granted: [Bug 67268] [NRWT] New tests without expected files are reported as flakey tests : [Attachment 110786] Revert some change in expected result

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 18:39:52 PDT 2011


Dirk Pranke <dpranke at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 67268: [NRWT] New tests without expected files are reported as flakey tests
https://bugs.webkit.org/show_bug.cgi?id=67268

Attachment 110786: Revert some change in expected result
https://bugs.webkit.org/attachment.cgi?id=110786&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
This patch looks okay, but it's definitely a hack that we're counting MISSING
tests as flaky, and I officially declare tthe logic in summarize_results and
get_failures to be too complicated, so we need to clean this up. Can you file a
separate bug for this effort?


More information about the webkit-reviews mailing list