[webkit-reviews] review granted: [Bug 69028] [chromium] Add a selectionBounds() method to WebWidget. : [Attachment 110751] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 17:48:17 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Peng Huang
<penghuang at chromium.org>'s request for review:
Bug 69028: [chromium] Add a selectionBounds() method to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=69028

Attachment 110751: Patch
https://bugs.webkit.org/attachment.cgi?id=110751&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110751&action=review


Otherwise, this patch looks fine to me.  R=me.

> Source/WebKit/chromium/src/WebViewImpl.h:123
> +    // TODO(penghuang): It has been replaced by selectionBounds. Remove it
when

nit: we use FIXME in WebKit instead of TODO(user)


More information about the webkit-reviews mailing list