[webkit-reviews] review granted: [Bug 63651] Update kill-old-processes logic : [Attachment 100356] Updated patch with ChangeLog corrections

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 16:55:30 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Lucas Forschler
<lforschler at apple.com>'s request for review:
Bug 63651: Update kill-old-processes logic
https://bugs.webkit.org/show_bug.cgi?id=63651

Attachment 100356: Updated patch with ChangeLog corrections
https://bugs.webkit.org/attachment.cgi?id=100356&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100356&action=review


Looks sane to me.

> Tools/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=63651
> +	   Update kill-old-processes logic.

The order in which bug title and url appear is wrong. Also you need a blank
line after these two lines. Please fix that before you land.


More information about the webkit-reviews mailing list