[webkit-reviews] review denied: [Bug 69963] InjectedBundleHitTestResult::imageRect() should return rect in WKView coordinates : [Attachment 110747] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jeff Miller
<jeffm at apple.com>'s request for review:
Bug 69963: InjectedBundleHitTestResult::imageRect() should return rect in
WKView coordinates
https://bugs.webkit.org/show_bug.cgi?id=69963

Attachment 110747: Patch
https://bugs.webkit.org/attachment.cgi?id=110747&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110747&action=review


>>> Source/WebKit2/ChangeLog:7
>>> +	     from frame to WKView coordinates.
>> 
>> Can you give a little justification as to why WKView coordinates are better
than whatever coordinates we were previously using?
> 
> The justification is in the comment in the code, but I'll elaborate in the
ChangeLog.

"ToWindow" really is window coords, not view coords. The coords will be flipped
in WK1.