[webkit-reviews] review granted: [Bug 69850] Enable out-of-thread compositing in WebKit compositor API : [Attachment 110536] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Antoine Labour
<piman at chromium.org>'s request for review:
Bug 69850: Enable out-of-thread compositing in WebKit compositor API
https://bugs.webkit.org/show_bug.cgi?id=69850

Attachment 110536: Patch
https://bugs.webkit.org/attachment.cgi?id=110536&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
R=me but there's still something a bit amiss here.  Right now there are 2 ways
to indicate threading support via the WK API - you can set the appropriate
CCSettings value and call WebCompositor::setThread(). If you do the former but
not the latter you hit ASSERT()s and crash today.  I think we want to just make
the latter be the control - if you pass a thread to WebCompositor::setThread()
then the compositor uses it, otherwise it runs single-threaded.

Does that sound like a good plan going forward, Nat?  To be clear I think this
patch is fine to land - we can clean things up later.