[webkit-reviews] review denied: [Bug 29447] Replaced elements squeezed when width is specified as percentage inside a table with Auto layout : [Attachment 109045] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 29447: Replaced elements squeezed when width is specified as percentage
inside a table with Auto layout
https://bugs.webkit.org/show_bug.cgi?id=29447

Attachment 109045: Patch
https://bugs.webkit.org/attachment.cgi?id=109045&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109045&action=review


> Source/WebCore/rendering/RenderBox.cpp:1244
> +int RenderBox::containingBlockReplacedLogicalWidthForContent() const

Should be LayoutUnit not int.

> Source/WebCore/rendering/RenderBox.cpp:1248
> +	   return max(shrinkToAvoidFloats() ?
cb->availableLogicalWidthForLine(y(), false) : cb->availableLogicalWidth(),
intrinsicLogicalWidth());

Should be logicalTop() not y().

> Source/WebCore/rendering/RenderBox.h:288
> +    int containingBlockReplacedLogicalWidthForContent() const;

Should be LayoutUnit not int.