[webkit-reviews] review denied: [Bug 10123] when CSS pseudo selectors are applied (:before and :after) the *-of-line keyboard navigation does not work : [Attachment 110666] Update on patch 109760

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Rosen Dash
<rosen.dash at motorola.com>'s request for review:
Bug 10123: when CSS pseudo selectors are applied (:before and :after) the
*-of-line keyboard navigation does not work
https://bugs.webkit.org/show_bug.cgi?id=10123

Attachment 110666: Update on patch 109760
https://bugs.webkit.org/attachment.cgi?id=110666&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110666&action=review


> Source/WebCore/editing/VisiblePosition.cpp:172
> +			   if (renderer->node() == m_deepPosition.anchorNode()
&& offset == m_deepPosition.offsetInContainerNode())
> +			       return Position();

When do we hit this case? You're essentially checking p == m_deepPosition here.
r- because of this.