[webkit-reviews] review denied: [Bug 69846] [chromium] Add a setSelectionOnFocusedFrame() method to WebWidget. : [Attachment 110720] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Nico Weber
<thakis at chromium.org>'s request for review:
Bug 69846: [chromium] Add a setSelectionOnFocusedFrame() method to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=69846

Attachment 110720: Patch
https://bugs.webkit.org/attachment.cgi?id=110720&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110720&action=review


> Source/WebKit/chromium/public/WebFrame.h:585
> +    virtual operator WTF::PassRefPtr<WebCore::Frame>() const = 0;

We normally cast WebFrame to WebFrameImpl to get at the WebCore::Frame.  There
is only one implementation of WebFrame in our system.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1103
> +	   RefPtr<Range> replacementRange =
static_cast<PassRefPtr<WebCore::Range> >(range);

is the static_cast really necessary?  won't it be implicitly invoked?

did you try RefPtr<Range> replacementRange(range) ?