[webkit-reviews] review granted: [Bug 69945] garden-o-matic should color-code test failure types. : [Attachment 110710] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 69945: garden-o-matic should color-code test failure types.
https://bugs.webkit.org/show_bug.cgi?id=69945

Attachment 110710: Patch
https://bugs.webkit.org/attachment.cgi?id=110710&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110710&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles
/notifications.css:205
> +

extra blank line

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles
/notifications.css:210
> +

ditto

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles
/notifications.css:219
> +    ol.notifications table.failures tbody tr.IMAGE\+TEXT td:first-child span
{

It's lame that span here is so unsemantic.  Would it be better to use a class
instead?