[webkit-reviews] review granted: [Bug 69788] Improve output of run-api-tests to make time-outs more obvious : [Attachment 110709] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 69788: Improve output of run-api-tests to make time-outs more obvious
https://bugs.webkit.org/show_bug.cgi?id=69788

Attachment 110709: Patch
https://bugs.webkit.org/attachment.cgi?id=110709&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110709&action=review


> Tools/Scripts/run-api-tests:133
> +	   for my $test (@testsTimedOut) {

I think you meant if (@testsTimedOut).

> Tools/Scripts/run-api-tests:214
> +    if ($result) {
> +	   push @testsFailed, $suite.".".$test;
> +    }
>      if ($timedOut) {
> +	   push @testsTimedOut, $suite.".".$test;

I think "$suite.$test" would be a little clearer.