[webkit-reviews] review denied: [Bug 69808] Implement -webkit-flex-align for cross axis alignment : [Attachment 110575] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 11:02:09 PDT 2011

Dave Hyatt <hyatt at apple.com> has denied Tony Chang <tony at chromium.org>'s
request for review:
Bug 69808: Implement -webkit-flex-align for cross axis alignment

Attachment 110575: Patch

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110575&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:571
> +	   case AlignStretch: {
> +	       Length height = isHorizontalFlow() ? child->style()->height() :
> +	       if (height.isAuto())
> +		   child->setLogicalHeight(child->logicalHeight() +
> +	       break;

This is wrong if the child is a perpendicular writing mode. You need
setLogicalHeightForChild and to use logicalHeightForChild, or you could just
use physical setters.

More information about the webkit-reviews mailing list