[webkit-reviews] review denied: [Bug 69917] Bug summary for Chromium DEPS roll to LKGR doesn't include revision number : [Attachment 110663] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 09:52:08 PDT 2011


Adam Barth <abarth at webkit.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 69917: Bug summary for Chromium DEPS roll to LKGR doesn't include revision
number
https://bugs.webkit.org/show_bug.cgi?id=69917

Attachment 110663: Patch
https://bugs.webkit.org/attachment.cgi?id=110663&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch looks correct, but I think we'll want a test.  You can look in
irc_command_unittest for examples.  We don't need an end-to-end test here, just
something simple.


More information about the webkit-reviews mailing list