[webkit-reviews] review denied: [Bug 69846] [chromium] Add a setSelectionOnFocusedFrame() method to WebWidget. : [Attachment 110621] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 09:43:03 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Nico Weber
<thakis at chromium.org>'s request for review:
Bug 69846: [chromium] Add a setSelectionOnFocusedFrame() method to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=69846

Attachment 110621: Patch
https://bugs.webkit.org/attachment.cgi?id=110621&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110621&action=review


I suspect we could probably clean up all of these functions that express
ranges.
The methods seem overly specific.  If we had the right primitives, we'd
probably
be much happier.

R- because of the nit.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1100
> +PassRefPtr<Range> convertToRange(Frame* frame, unsigned start, unsigned
length)

nit: this should be a 'static' function.  please move it up to the top of the
file so it
does not interrupt the flow of WebFrameImpl methods.


More information about the webkit-reviews mailing list