[webkit-reviews] review denied: [Bug 45778] CSSStyleDeclaration.prototype.setProperty does not set priority correctly : [Attachment 96211] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 12 08:37:52 PDT 2011
Alexey Proskuryakov <ap at webkit.org> has denied Jason
<liuyang12341982 at 163.com>'s request for review:
Bug 45778: CSSStyleDeclaration.prototype.setProperty does not set priority
correctly
https://bugs.webkit.org/show_bug.cgi?id=45778
Attachment 96211: Patch
https://bugs.webkit.org/attachment.cgi?id=96211&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
LayoutTests/css1 is a location for official CSS 1 test suite. This new test
should be added to fast/dom/CSSStyleDeclaration directory.
It should also be a text-only test, so that all platforms could share results
without trouble. You can read back resulting style with getComputedStyle(). I
recommend that you re-create the test using make-new-script-test script, which
will add boilerplate for this style of test:
make-new-script-test fast/dom/CSSStyleDeclaration/setProperty-important.html
Sorry about slow review turnaround.
More information about the webkit-reviews
mailing list