[webkit-reviews] review denied: [Bug 69097] REGRESSION (r95381): Standalone video can be focused and draws a focus ring : [Attachment 110673] Updated Patch with review comments.

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Deepak Sherveghar
<bpwv64 at motorola.com>'s request for review:
Bug 69097: REGRESSION (r95381): Standalone video can be focused and draws a
focus ring
https://bugs.webkit.org/show_bug.cgi?id=69097

Attachment 110673: Updated Patch with review comments.
https://bugs.webkit.org/attachment.cgi?id=110673&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110673&action=review


This is really close, but I think it makes sense to correct the one mistake
before committing.

>
LayoutTests/fast/events/media-focus-in-standalone-media-document-expected.txt:1
1
> +*** Video element clicked.
> +
> +*** Should not focus video element by mouse click.
> +EXPECTED (standaloneMediaDocument.activeElement != '[object
HTMLVideoElement]') OK

The results are confusing, it looks like the click event happens before the
test...

> LayoutTests/fast/events/media-focus-in-standalone-media-document.html:43
> +		   videoElement.dispatchEvent(click);
> +		   consoleWrite("<br>*** Should not focus video element by
mouse click.");
> +		   testExpected("standaloneMediaDocument.activeElement",
videoElement, "!=");

because you dispatch the event before you write the comment about what is being
tested.