[webkit-reviews] review requested: [Bug 69747] FEComponentTransfer element doesn't support dynamic invalidation : [Attachment 110679] Propsed patch

[bugzilla-daemon at webkit.org]

Renata Hodovan <reni at webkit.org> has asked  for review:
Bug 69747: FEComponentTransfer element doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=69747

Attachment 110679: Propsed patch
https://bugs.webkit.org/attachment.cgi?id=110679&action=review

------- Additional Comments from Renata Hodovan <reni at webkit.org>
> Tests look great, I checked each of them. I wish the changes would be more
easily visible (did the filter apply really work?) I have to trust you all
tests work manually fine and produce this result which is different to no
filter applied :-)
Yeah, tests work manually fine. Perhaps you don't see it on the pngs, because
the second pricture tries to approach the input image (e.g. the second
parameter set contains the default values) and it's printed to the png.

Furthermore I renamed invalidateParents() to invalidateFilterPrimitiveParent()
and moved to SVGFilterPrimitveStandardAttributes. As we talked on IRC it's
declared as a free function.